Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: properly display header on landing page #44

Merged
merged 10 commits into from
Apr 8, 2024
Merged

Conversation

MateuszRostkowski
Copy link
Collaborator

Description

Done:

  • add full screen modal and hooks to use it easily
  • improve header on landing page for mobiles

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run web app -> open landing screen

Screenshot(s)

Please attach some screenshot or a movie if provided changes affects UI.

Nagranie.z.ekranu.2024-04-6.o.16.13.27.mov

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • Add correct label to your pull request
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

src/design-system/modals/FullScreenModal.tsx Outdated Show resolved Hide resolved
@MateuszRostkowski MateuszRostkowski merged commit 8763bed into main Apr 8, 2024
1 check passed
@MateuszRostkowski MateuszRostkowski deleted the fix/modals branch April 22, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants